-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change all the references of default_filter
to human_friendly_id
#4682
Conversation
“suresh” seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Changed all the references from 'default_filter' to 'human_friendly_id: ["name__value"]' PS - Assign it to petercrocker |
@@ -275,7 +275,7 @@ nodes: | |||
description: "A Circuit represent a single physical link between two locations" | |||
label: "Circuit" | |||
icon: "mdi:transit-connection-variant" | |||
default_filter: circuit_id__value | |||
human_friendly_id: ["name__value"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think circuit has a name, guess it should be "circuit_id__value"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've amended now
models/examples/netbox/netbox.yml
Outdated
@@ -242,7 +242,7 @@ nodes: | |||
description: "A Circuit represent a single physical link between two locations" | |||
label: "Circuit" | |||
icon: "mdi:transit-connection-variant" | |||
default_filter: circuit_id__value | |||
human_friendly_id: ["name__value"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the above, it should be circuit_id__value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BaptisteGi I've changed them all now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems they're correct for every one but this one on line 245 of netbox.yml?
default_filter
to human_friendly_id
default_filter
to human_friendly_id
default_filter
to human_friendly_id
38db33f
to
07aa933
Compare
4eef597
to
1682484
Compare
1682484
to
7d1111d
Compare
Still need to test infrahub-sync with updated netbox/nautobot schema |
No description provided.